Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prometheus metric #19452

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add prometheus metric #19452

wants to merge 1 commit into from

Conversation

gangli113
Copy link
Contributor

@gangli113 gangli113 commented Feb 20, 2025

Fix #19324

Add a prometheus metric etcd_server_feature_enabled

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gangli113
Once this PR has been reviewed and has the lgtm label, please assign ahrtr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @gangli113. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Gang Li <[email protected]>
Signed-off-by: Gang Li <[email protected]>
Copy link
Contributor Author

@gangli113 gangli113 Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because I added prometheus and prometheus/testutil to feature_gate.go. it requires me to run go mod tidy, otherwise build failed. The command modified go.mod and go.sum, do I need to submit these change in PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, you should include the dependency changes in the PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you need to run go mod tidy in some other places as well.

@gangli113
Copy link
Contributor Author

gangli113 commented Feb 21, 2025

/cc @ahrtr

@gangli113
Copy link
Contributor Author

sorry @ahrtr, assign to you by mistake. I was trying to add you to reviewer list.

@gangli113
Copy link
Contributor Author

/cc @ahrtr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Add Prometheus gauge metrics for server feature gate
5 participants