[3.6] Backport DowngradeInfo proto change #19471
Merged
+776
−357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wei Fu <[email protected]> (cherry picked from commit 9d57554) Signed-off-by: Wei Fu <[email protected]>
Signed-off-by: Wei Fu <[email protected]> (cherry picked from commit 8575de3) Signed-off-by: Wei Fu <[email protected]>
Signed-off-by: Wei Fu <[email protected]> (cherry picked from commit 091b6ed) Signed-off-by: Wei Fu <[email protected]>
1. Update DowngradeUpgradeMembersByID If it's downgrading process, the desire version of cluster should be target one. If it's upgrading process, the desire version of cluster should be determined by mininum binary version of members. 2. Remove AssertProcessLogs from DowngradeEnable The log message "The server is ready to downgrade" appears only when the storage version monitor detects a mismatch between the cluster and storage versions. If traffic is insufficient to trigger a commit or if an auto-commit occurs right after reading the storage version, the monitor may fail to update it, leading to errors like: ```bash "msg":"failed to update storage version","cluster-version":"3.6.0", "error":"cannot detect storage schema version: missing confstate information" ``` Given this, we should remove the AssertProcessLogs statement. Similar to etcd-io#19313 Signed-off-by: Wei Fu <[email protected]> (cherry picked from commit 65159a2) Signed-off-by: Wei Fu <[email protected]>
Fixes: 65159a2 (*: Update cases related to Downgrade) Signed-off-by: Wei Fu <[email protected]> (cherry picked from commit 2de17bd) Signed-off-by: Wei Fu <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 22 files with indirect coverage changes @@ Coverage Diff @@
## release-3.6 #19471 +/- ##
===============================================
- Coverage 68.99% 68.97% -0.03%
===============================================
Files 420 420
Lines 35753 35762 +9
===============================================
- Hits 24669 24666 -3
- Misses 9662 9674 +12
Partials 1422 1422 Continue to review full report in Codecov by Sentry.
|
ahrtr
approved these changes
Feb 23, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Link to #19456 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick:
#19451
#19461
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.