Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/state/snapshot: soften log message when snapshot generation is paused #31195

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Feb 17, 2025

For #31184

@rjl493456442
Copy link
Member

Abort is actually the right term here.

Snapshot generation occurs in multiple cycles and will be aborted
and restarted if the persistent state changes (the generation target
switches).

If the chain progresses, the process is aborted when a new state
layer is added on top, flooding users with excessive logs.

Fortunately, with #30661,
snapshot generation is now only aborted when the accumulated content
in the write buffer exceeds the threshold, significantly reducing the
frequency of interruptions.

@MariusVanDerWijden
Copy link
Member

Maybe interrupting? I also think abort is a bit too strong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants