Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying groups option in submit command #2891

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

khamilowicz
Copy link
Contributor

@khamilowicz khamilowicz commented Feb 7, 2025

Why

ENG-14634: Add support for groups option in fastlane pilot call

User should be able to pass the groups option to fastlane pilot when submitting an iOS build.

How

  • Accept the groups flag in the eas submit command
  • Pass this parameter to the submission-config

Test Plan

  1. Build the project
  2. Run the eas submit -p ios --groups "Test 1" command
  3. Check the submission logs

Deployment plan

  1. https://github.com/expo/turtle-v2/pull/2082
  2. https://github.com/expo/universe/pull/18600
  3. Allow specifying groups option in submit command #2891

Copy link

linear bot commented Feb 7, 2025

Copy link

github-actions bot commented Feb 7, 2025

Size Change: -1.2 kB (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB -1.2 kB (0%)

compressed-size-action

@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-14634-add-support-for-groups-option-in-fastlane-pilot-call branch 2 times, most recently from 7b78b7f to 7408a04 Compare February 7, 2025 16:36
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-14634-add-support-for-groups-option-in-fastlane-pilot-call branch from 7408a04 to 4892814 Compare February 7, 2025 17:02
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.63%. Comparing base (f334bdb) to head (392e8eb).

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/submit.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2891      +/-   ##
==========================================
- Coverage   52.63%   52.63%   -0.00%     
==========================================
  Files         588      588              
  Lines       23183    23184       +1     
  Branches     4854     4855       +1     
==========================================
  Hits        12201    12201              
- Misses      10016    10017       +1     
  Partials      966      966              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khamilowicz
Copy link
Contributor Author

/changelog-entry new-feature Add groups option to eas submit command.

Copy link

github-actions bot commented Feb 7, 2025

✅ Thank you for adding the changelog entry!

@khamilowicz khamilowicz marked this pull request as ready for review February 10, 2025 09:23
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant