Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue: Cannot publish tweet if it is too long #50

Merged
merged 3 commits into from
Mar 14, 2022
Merged

Fix issue: Cannot publish tweet if it is too long #50

merged 3 commits into from
Mar 14, 2022

Conversation

Shubhcoder
Copy link
Contributor

Fixes #40

Changes in brief:-

  1. Added a function to check for content to make sure it is within limit(truncates description, if required).
  2. Added test for above function.

Note --> I am new to both open source and github community. So, I will be happy to receive feedbacks.

@Shubhcoder
Copy link
Contributor Author

Shubhcoder commented Mar 13, 2022 •
edited
Loading

Hi, @ezeoleaf

Thank you for your feedback. I have fixed the issues as per your observations.

Please take a look at it.

@ezeoleaf ezeoleaf merged commit 0a17f87 into ezeoleaf:main Mar 14, 2022
@ezeoleaf
Copy link
Owner

Hi, @ezeoleaf

Thank you for your feedback. I have fixed the issues as per your observations.

Please take a look at it.

Nice work @Shubhcoder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezeoleaf ezeoleaf ezeoleaf left review comments

Assignees

@Shubhcoder Shubhcoder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tweet cannot be published if it is too long
2 participants
@Shubhcoder @ezeoleaf