Reland: Throw exception with name of TurboModule instead of deadlock during sync rendering #49587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…during sync rendering Summary: This is a reland diff for D69805065. The problems with the original diff were: - wrong header search path in the `React-NativeModuleApple.podspec` - adding an implementation `RuntimeExecutor.cpp` file to implement a function that is used by an inline function in the `RuntimeExecutor.h`. I believe that the last point specifically was creating issues to the linker which was not able to resolve the symbols properly in transitive dependencies. The fix was to move the implementation of `getMainThreadMutex` to be `inline`. ## Changelog: [Internal] Differential Revision: D69922771
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69922771 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a reland diff for D69805065.
The problems with the original diff were:
React-NativeModuleApple.podspecRuntimeExecutor.cppfile to implement a function that is used by an inline function in theRuntimeExecutor.h.I believe that the last point specifically was creating issues to the linker which was not able to resolve the symbols properly in transitive dependencies.
The fix was to move the implementation of
getMainThreadMutexto beinline.Changelog:
[Internal]
Differential Revision: D69922771