Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pod spec to 1.8.0, set explicit public header files #726

Closed
wants to merge 2 commits into from
Closed

Update pod spec to 1.8.0, set explicit public header files #726

wants to merge 2 commits into from

Conversation

a2
Copy link

@a2 a2 commented Mar 8, 2018

  • Update pod specs to version 1.8.0 (most recent tag)
  • Mark Yoga.h, YGEnums.h, and YGMacros.h as public headers

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired.

Before we can review or merge your code, we need you to email [email protected] with your details so we can update your status.

@muukii
Copy link

muukii commented Mar 16, 2018

I need this!

@orta orta mentioned this pull request Mar 21, 2018
Closed
@a2
Copy link
Author

a2 commented Mar 21, 2018

Reiterating this from facebookarchive/rebound-js#49, I sent the CLA to the contact who replied to my email and never heard back. Is it possible for my CLA status to be updated?

facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Mar 21, 2018
@orta @facebook-github-bot
Updates Yoga to handle being in a Xcode framework project
cf036db 
Summary:
Updates the Yoga Podspec to work with Cocoa frameworks. Replicated a2's work over on Yoga facebook/yoga#726

(Which should also get merged too please ❤️ )

Set it manually in my own project and tested 👍

Only facebook/yoga#726

[IOS] [BUGFIX] [Yoga] - Fixes to yoga.podspec when integrating into an iOS app using Cocoa frameworks.
Closes #18492

Differential Revision: D7355907

Pulled By: hramos

fbshipit-source-id: 6986d2bc560a23bb7f0f20b80e88bb440079891a
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

hamaron pushed a commit to hamaron/react-native that referenced this pull request Apr 9, 2018
@orta @hamaron
Updates Yoga to handle being in a Xcode framework project
111fd83 
Summary:
Updates the Yoga Podspec to work with Cocoa frameworks. Replicated a2's work over on Yoga facebook/yoga#726

(Which should also get merged too please ❤️ )

Set it manually in my own project and tested 👍

Only facebook/yoga#726

[IOS] [BUGFIX] [Yoga] - Fixes to yoga.podspec when integrating into an iOS app using Cocoa frameworks.
Closes facebook#18492

Differential Revision: D7355907

Pulled By: hramos

fbshipit-source-id: 6986d2bc560a23bb7f0f20b80e88bb440079891a
campsafari pushed a commit to exozet/react-native that referenced this pull request Apr 11, 2018
@orta @campsafari
Updates Yoga to handle being in a Xcode framework project
6d27609 
Summary:
Updates the Yoga Podspec to work with Cocoa frameworks. Replicated a2's work over on Yoga facebook/yoga#726

(Which should also get merged too please ❤️ )

Set it manually in my own project and tested 👍

Only facebook/yoga#726

[IOS] [BUGFIX] [Yoga] - Fixes to yoga.podspec when integrating into an iOS app using Cocoa frameworks.
Closes facebook#18492

Differential Revision: D7355907

Pulled By: hramos

fbshipit-source-id: 6986d2bc560a23bb7f0f20b80e88bb440079891a
LukeDurrant pushed a commit to LukeDurrant/react-native that referenced this pull request Apr 11, 2018
@orta @LukeDurrant
Updates Yoga to handle being in a Xcode framework project
b6ff46b 
Summary:
Updates the Yoga Podspec to work with Cocoa frameworks. Replicated a2's work over on Yoga facebook/yoga#726

(Which should also get merged too please ❤️ )

Set it manually in my own project and tested 👍

Only facebook/yoga#726

[IOS] [BUGFIX] [Yoga] - Fixes to yoga.podspec when integrating into an iOS app using Cocoa frameworks.
Closes facebook#18492

Differential Revision: D7355907

Pulled By: hramos

fbshipit-source-id: 6986d2bc560a23bb7f0f20b80e88bb440079891a
LukeDurrant pushed a commit to LukeDurrant/react-native that referenced this pull request Apr 11, 2018
@orta @LukeDurrant
Updates Yoga to handle being in a Xcode framework project
65e1838 
Summary:
Updates the Yoga Podspec to work with Cocoa frameworks. Replicated a2's work over on Yoga facebook/yoga#726

(Which should also get merged too please ❤️ )

Set it manually in my own project and tested 👍

Only facebook/yoga#726

[IOS] [BUGFIX] [Yoga] - Fixes to yoga.podspec when integrating into an iOS app using Cocoa frameworks.
Closes facebook#18492

Differential Revision: D7355907

Pulled By: hramos

fbshipit-source-id: 6986d2bc560a23bb7f0f20b80e88bb440079891a
bunnyc1986 pushed a commit to bunnyc1986/react-native that referenced this pull request May 11, 2018
@orta @bunnyc1986
Updates Yoga to handle being in a Xcode framework project
7a634af 
Summary:
Updates the Yoga Podspec to work with Cocoa frameworks. Replicated a2's work over on Yoga facebook/yoga#726

(Which should also get merged too please ❤️ )

Set it manually in my own project and tested 👍

Only facebook/yoga#726

[IOS] [BUGFIX] [Yoga] - Fixes to yoga.podspec when integrating into an iOS app using Cocoa frameworks.
Closes facebook#18492

Differential Revision: D7355907

Pulled By: hramos

fbshipit-source-id: 6986d2bc560a23bb7f0f20b80e88bb440079891a
vovkasm pushed a commit to vovkasm/react-native that referenced this pull request Jun 5, 2018
@orta @vovkasm
Updates Yoga to handle being in a Xcode framework project
66c6329 
Summary:
Updates the Yoga Podspec to work with Cocoa frameworks. Replicated a2's work over on Yoga facebook/yoga#726

(Which should also get merged too please ❤️ )

Set it manually in my own project and tested 👍

Only facebook/yoga#726

[IOS] [BUGFIX] [Yoga] - Fixes to yoga.podspec when integrating into an iOS app using Cocoa frameworks.
Closes facebook#18492

Differential Revision: D7355907

Pulled By: hramos

fbshipit-source-id: 6986d2bc560a23bb7f0f20b80e88bb440079891a
macdoum1 pushed a commit to macdoum1/react-native that referenced this pull request Jun 28, 2018
@orta @macdoum1
Updates Yoga to handle being in a Xcode framework project
570c725 
Summary:
Updates the Yoga Podspec to work with Cocoa frameworks. Replicated a2's work over on Yoga facebook/yoga#726

(Which should also get merged too please ❤️ )

Set it manually in my own project and tested 👍

Only facebook/yoga#726

[IOS] [BUGFIX] [Yoga] - Fixes to yoga.podspec when integrating into an iOS app using Cocoa frameworks.
Closes facebook#18492

Differential Revision: D7355907

Pulled By: hramos

fbshipit-source-id: 6986d2bc560a23bb7f0f20b80e88bb440079891a
@NickGerleman
Copy link
Contributor

It looks like the underlying code has been updated. The podspec is a newer version, and the headers are now public, since the RN build used them (though I'm not sure this is the right boundary to expose).

@a2 a2 deleted the podspec-1.8.0 branch November 6, 2022 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Build and Infrastructure CLA Signed YogaKit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a2 @facebook-github-bot @muukii @NickGerleman