Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): MFA Support for GoLang createUser, updateUser #511

Merged
merged 8 commits into from
Nov 9, 2022

Conversation

pragatimodi
Copy link
Contributor

No description provided.

@pragatimodi pragatimodi changed the base branch from master to dev October 4, 2022 21:01
@pragatimodi pragatimodi requested a review from prameshj October 5, 2022 23:50
Copy link

@prameshj prameshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add integration tests for create and update user. Once that's done and the comments here are addressed, feel free to get review from @lahirumaramba and submit. Thanks!

@lahirumaramba lahirumaramba changed the title MFA Support for GoLang createUser, updateUser feat(auth): MFA Support for GoLang createUser, updateUser Oct 28, 2022
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM!

@lahirumaramba
Copy link
Member

Adding @kevinthecheung to review the reference doc changes. Thank you!

@brokeyourbike
Copy link
Contributor

Hi @lahirumaramba @kevinthecheung , when do you think this can be merged?

@pragatimodi pragatimodi force-pushed the master branch 2 times, most recently from 23a1f17 to 1f84f17 Compare November 9, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants