Snapshot editor #4045
Merged
Snapshot editor #4045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4045 +/- ##
==========================================
- Coverage 82.70% 82.37% -0.33%
==========================================
Files 220 224 +4
Lines 28253 28398 +145
==========================================
+ Hits 23366 23393 +27
- Misses 4887 5005 +118
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
ShadowCurse
force-pushed
the
snapshot_editor
branch
9 times, most recently
from
491698c to
8c8570b
Compare
ShadowCurse
added
the
Status: Awaiting review
ShadowCurse
force-pushed
the
snapshot_editor
branch
from
a031d4e to
f0085ec
Compare
roypat
reviewed
Aug 21, 2023
roypat
previously approved these changes
Aug 21, 2023
ShadowCurse
force-pushed
the
snapshot_editor
branch
11 times, most recently
from
27f5609 to
fded9a4
Compare
ShadowCurse
force-pushed
the
snapshot_editor
branch
2 times, most recently
from
17df589 to
5bde3be
Compare
bchalios
reviewed
Aug 23, 2023
ShadowCurse
force-pushed
the
snapshot_editor
branch
6 times, most recently
from
f6e2bd5 to
39ee5ef
Compare
Modified snapshot loading code to return version along side the deserialized object. Signed-off-by: Egor Lazarchuk <[email protected]>
These changes (and one in the next commit) are needed to be able to use `MicrovmState::default()`. This is needed to test `snapshot-editor`. Signed-off-by: Egor Lazarchuk <[email protected]>
These changes are needed for `snapshot-editor` (added in next commits) to access internal `vmm` structs. Signed-off-by: Egor Lazarchuk <[email protected]>
After making several modules public in previous commit, we need to add comments to all public members because of `missing_doc` lint that we have. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
snapshot_editor
branch
4 times, most recently
from
c1da82c to
c6c8b71
Compare
roypat
previously approved these changes
Aug 24, 2023
Added snapshot-editor tool with minimal initial functionality. So far it can: - print snapshot version - (aarch64 only) remove registers from vcpu states - (aarch64 only) print registers inside vcpu states Signed-off-by: Egor Lazarchuk <[email protected]>
Added initial documentation for `snapshot-editor` tool. Signed-off-by: Egor Lazarchuk <[email protected]>
Added integration test for `snapshot-editor` to test `remove-regs` functionality. Signed-off-by: Egor Lazarchuk <[email protected]>
Added `snapshot-editor` to the CHANGELOG Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
snapshot_editor
branch
from
c6c8b71 to
3319a27
Compare
bchalios
approved these changes
Aug 25, 2023
roypat
approved these changes
Aug 25, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added initial version of
snapshot-editortool.Initial functionality is:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.