[1.9] fix tap offload features on restore and debuginfo #4829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tap offload features configuration was moved from the device creation time to the device activation time by the following commit: commit 1e5d3db Author: Nikita Zakirov <[email protected]> Date: Fri Jan 19 15:48:21 2024 +0000 fix(net): Apply only supported TAP offloading features Since device activation code is only called on the boot path, the features were not automatically configured on the restore path. This change configures them on the restore path as well. The change does not include a unit test as we do not have a mockable interface for the tap device. The change does not include an integration test as we have not yet found a way to reproduce the issue using the existing test framework. Signed-off-by: Nikita Kalyazin <[email protected]>
The idea here is that these tests depend on the compilation step, and thus test a production binary. This smells "integration" to me. The actual reason for moving this however is so that we can have the `build` group no longer depend on the shared compilation step. Signed-off-by: Patrick Roy <[email protected]>
Seems recently Cargo defaulted to use `strip=debuginfo`. This inadvertently made our debuginfo files much smaller Fix the issue by using `strip=none` and add a test so that it breaks if this somehow changes again. Signed-off-by: Pablo Barbáchano <[email protected]>
kalyazin
force-pushed
the
debuginfo_1.9
branch
from
6a3c0b4 to
f1a09cf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## firecracker-v1.9 #4829 +/- ##
====================================================
- Coverage 84.34% 84.33% -0.02%
====================================================
Files 249 249
Lines 27461 27465 +4
====================================================
Hits 23162 23162
- Misses 4299 4303 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kalyazin
added
the
Status: Awaiting review
pb8o
approved these changes
Oct 2, 2024
kalyazin
changed the title
ShadowCurse
approved these changes
Oct 2, 2024
kalyazin
merged commit 71e478d
into
firecracker-microvm:firecracker-v1.9
7 of 8 checks passed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Cherry-pick from #4826, #4790 and its dependency.
Reason
Backporting.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
[ ] If a specific issue led to this PR, this PR closes the issue.PR.
[ ] API changes follow the Runbook for Firecracker API changes.CHANGELOG.md.[ ] All added/changed functionality is tested.[ ] NewTODOs link to an issue.contribution quality standards.
rust-vmm.