Skip to content

fleetctl npm publish always tagged as "latest" #26520

Open
@sgress454

Description

💥  Actual behavior

Whenever we publish a new version of the fleetctl npm installer, it gets tagged as "latest", even if it's a patch release of an earlier version. For example, if we publish 4.63.2 after 4.64.0, then 4.63.2 will be tagged as "latest" and anyone just doing npm install fleetctl will not get the latest version.

🛠️ To fix

Before running npm publish, we should check the version of the current latest tag against the one we're trying to publish, and if the new version is < the latest tag, give it a different tag (like v4.63).

Notes

In our suggested Gitops workflow, the npm install fleetctl tries to use the version returned from the Fleet server, so as long as the server isn't an unreleased version (e.g. from the main branch) this isn't an issue. But it would still affect anyone using npm install fleetctl directly (without specifying a version). The NPM page and npm show also show misleading info about what the latest version is in this scenario, so IMO it's worth fixing.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

#g-orchestrationOrchestration product group:releaseReady to write code. Scheduled in a release. See "Making changes" in handbook.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions