Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve sanitation of python version strings to match CPEs #26538

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jahzielv
Copy link
Contributor

@jahzielv jahzielv commented Feb 21, 2025

for #25991

Screenshot 2025-02-21 at 3 33 00 PM

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated automated tests
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.84%. Comparing base (aa16261) to head (423a8c7).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #26538      +/-   ##
==========================================
- Coverage   63.85%   63.84%   -0.02%     
==========================================
  Files        1661     1662       +1     
  Lines      159221   159297      +76     
  Branches     4181     4181              
==========================================
+ Hits       101671   101699      +28     
- Misses      49613    49657      +44     
- Partials     7937     7941       +4     
Flag Coverage Δ
backend 64.67% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jahzielv jahzielv marked this pull request as ready for review February 21, 2025 22:11
@jahzielv jahzielv requested a review from a team as a code owner February 21, 2025 22:11
@jahzielv jahzielv assigned jahzielv and ksykulev and unassigned jahzielv Feb 21, 2025
includedCVEs: []cve{
{
ID: "CVE-2024-12254",
resolvedInVersion: "3.12.9",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like it should be 3.14.0a3, per https://www.cve.org/CVERecord?id=CVE-2024-12254

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iansltx could this be an issue with the semver changes we made recently?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. Would probably require digging into the vuln feed to see the information that's there. As mentioned in chat, I think that the CPE wouldn't even generate without the recent fix in place, but maybe we're matching the wrong CPE?

@iansltx iansltx assigned iansltx and unassigned ksykulev Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants