Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON logging, log.S #22

Merged
merged 14 commits into from
Jun 14, 2023
Merged

JSON logging, log.S #22

merged 14 commits into from
Jun 14, 2023

Conversation

ldemailly
Copy link
Member

@ldemailly ldemailly commented May 7, 2023

Alternative to https://pkg.go.dev/golang.org/x/exp/slog but handcrafted JSON output instead

Fixes #21

@codecov
Copy link

codecov bot commented May 7, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (410963b) 100.00% compared to head (2163e6e) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          166       243   +77     
=========================================
+ Hits           166       243   +77     
Impacted Files Coverage Δ
http_logging.go 100.00% <100.00%> (ø)
logger.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ldemailly ldemailly changed the title JSON logging JSON logging, log.S May 9, 2023
@ldemailly
Copy link
Member Author

will merge and do release tags if the fortiotel with 1.9.0-pre1 using the whole chain (log->scli->fortio->fortiotel) works well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use slog / json option
2 participants