-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add button-full-width class to Button component #1
Conversation
readme.md
Outdated
@@ -102,6 +102,7 @@ app.mount("#app"); | |||
<Button icon-left="menu">Menu</Button> | |||
<Button icon-right="external-link">Link</Button> | |||
<Button :loading="true">Loading</Button> | |||
<Button :button-full-width="true">Full Width Button</Button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Button :button-full-width="true">Full Width Button</Button> | |
<Button :full-width="true">Full Width Button</Button> |
Button is redundant anyways, the readability remains same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I was going to do the same, but the naming which was used in the Dropdown component for this class is this
frappe-ui/src/components/Dropdown.vue
Lines 85 to 88 in b1dc1ff
dropdownWidthFull: { | |
type: Boolean, | |
default: false, | |
}, |
I named the class in the same way to maintain consistency throughout.
I too think we should just use full-width instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have refactored the class tag from button-full-width
-> width-full
Feature
Added class
button-full-width
which when set to true will set the button width to the element width that it is contained in, Itis set to false as default
.How to use
In action
When used within other components