Performance regression when scrolling inside the file dialog

[alexballas]

Checklist

• I have searched the issue tracker for open issues that relate to the same problem, before opening a new one.
• This issue only relates to a single bug. I will open new issues for any other problems.

Describe the bug

File dialog file scrolling is much slower in version 2.4.x compared to the previous ones. Check video

How to reproduce

check video

Screenshots

2023-10-10_21-04-58.mp4

Example code

No code required

Fyne version

v2.4.0, v2.4.1

Go compiler version

1.20.2

Operating system and version

Ubuntu 18.04

Additional Information

No response

[JordanGoulder]

Which version is the previous version you are comparing it to?

[alexballas]

Hello @JordanGoulder. Apologies for missing this. The old one is on version v2.3.2

[alexballas]

Hello @andydotxyz, just wanted to confirm. Is this still planned to be looked at as part of the 2.4.x fixes or are you now aiming to get something in the upcoming 2.5.x releases?

[andydotxyz]

Hello @andydotxyz, just wanted to confirm. Is this still planned to be looked at as part of the 2.4.x fixes or are you now aiming to get something in the upcoming 2.5.x releases?

Apologies I missed this message. We are trying to prioritise it for the coming bug fix release.

[andydotxyz]

Good catch there was a big impact from an image refresh logic change that meant we were forcefully refreshing an icon every time it was added/removed which is a lot of overhead we didn't need.

Hopefully the PR addresses that!

[andydotxyz]

Fixed on develop and will be in v2.5.3