Skip to content

Commit

Permalink
fix(cartridge): Fix panic when invalid ROM file is loaded
Browse files Browse the repository at this point in the history
  • Loading branch information
gabe565 committed Aug 13, 2024
1 parent 4e07c57 commit 5dd8c28
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions internal/cartridge/ines.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,14 @@ func FromiNesFile(path string) (*Cartridge, error) {
}(f)

cartridge, err := FromiNes(f)
if err != nil {
return nil, err
}

if cartridge.name == "" {
cartridge.name = strings.TrimSuffix(filepath.Base(path), filepath.Ext(path))
}

return cartridge, err
return cartridge, nil
}

func FromiNes(r io.ReadSeeker) (*Cartridge, error) {
Expand Down

0 comments on commit 5dd8c28

Please sign in to comment.