Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install script fixes #146

Merged
merged 6 commits into from
Mar 21, 2024
Merged

Install script fixes #146

merged 6 commits into from
Mar 21, 2024

Conversation

mruz
Copy link
Contributor

@mruz mruz commented Mar 19, 2024

On openSUSE I have just linux in $OSTYPE and filenames have macos in the name https://github.com/gabyx/Githooks/releases/tag/v2.8.0

@mruz mruz changed the title Fix for opensuse linux Install script fixes Mar 19, 2024
@mruz mruz marked this pull request as ready for review March 19, 2024 11:59
@gabyx
Copy link
Owner

gabyx commented Mar 19, 2024

This is good to go, some small change needed since I want to leave darwin in there, because its not necessary to change it. might be to brittle.

@mruz
Copy link
Contributor Author

mruz commented Mar 20, 2024

For darwin I'm getting:
image (8)

@mruz
Copy link
Contributor Author

mruz commented Mar 20, 2024

$ curl --silent --location https://api.github.com/repos/gabyx/Githooks/releases/tags/v2.8.0 \
    | jq --raw-output ".assets[] | select( (.name | contains(\"darwin\")) and (.name | contains(\"arm64\")) ) | .browser_download_url"

$ curl --silent --location https://api.github.com/repos/gabyx/Githooks/releases/tags/v2.8.0 \
    | jq --raw-output ".assets[] | select( (.name | contains(\"macos\")) and (.name | contains(\"arm64\")) ) | .browser_download_url"
https://github.com/gabyx/Githooks/releases/download/v2.8.0/githooks-2.8.0-macos.arm64.tar.gz

@gabyx
Copy link
Owner

gabyx commented Mar 21, 2024

Ah, ok thanks for the hint! But could you leave darwin in the paltform script and make an darwin to macos overwrite in the install.sh script. That might be better!

Thanks for the patch.

@gabyx
Copy link
Owner

gabyx commented Mar 21, 2024

@mruz : I changed it, will merge in a second.

@gabyx gabyx merged commit 4326c68 into gabyx:main Mar 21, 2024
@mruz mruz deleted the install-fix branch March 22, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants