Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixbug: llm.timeout not working #1060

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Conversation

iorisa
Copy link
Collaborator

@iorisa iorisa commented Mar 20, 2024

Features
fixbug: #1059

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 81.63%. Comparing base (adb42f4) to head (b42cf5c).
Report is 4 commits behind head on main.

Files Patch % Lines
metagpt/configs/llm_config.py 83.33% 1 Missing ⚠️
metagpt/provider/base_llm.py 92.30% 1 Missing ⚠️
metagpt/provider/openai_api.py 90.90% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1060      +/-   ##
==========================================
- Coverage   81.70%   81.63%   -0.08%     
==========================================
  Files         246      246              
  Lines       13734    13752      +18     
==========================================
+ Hits        11221    11226       +5     
- Misses       2513     2526      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@geekan geekan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I think this still costs understanding, it may solve part of the problem.

@iorisa iorisa requested a review from geekan March 21, 2024 05:26
@iorisa iorisa added the bug-fix label Mar 21, 2024
@geekan geekan merged commit 0e2a578 into geekan:main Mar 21, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants