Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade langchain to support new openai #605

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Upgrade langchain to support new openai #605

merged 3 commits into from
Dec 22, 2023

Conversation

seehi
Copy link
Contributor

@seehi seehi commented Dec 22, 2023

Context

The upgrade of OpenAI, leaving Langchain unupgraded, has resulted in issues with Faiss.

Amendments details

  1. Upgrade Langchain 0.0.231 -> 0.0.352, supporting OpenAI v1.
  2. Use Langchain faiss's load/save functions to simplify the code, because after upgrading Langchain, the original code will throw an error "pickle.dump(store, f)TypeError: cannot pickle '_thread.RLock' object".
  3. Simplify the example/search_kb.py code.

@geekan geekan merged commit 6bae6f7 into geekan:main Dec 22, 2023
1 check passed
@seehi seehi deleted the feature-upgrade-langchain branch December 27, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seehi @geekan