Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat add qianfan and dashscope #940

Merged
merged 14 commits into from
Feb 28, 2024
Merged

Conversation

better629
Copy link
Collaborator

Features

  • add baidu qianfan
  • add alibaba dashscope
  • update repair_llm new case

Feature Docs

https://github.com/geekan/MetaGPT-docs/blob/main/src/en/guide/get_started/configuration.md#baidu-qianfan-api

Influence

Result

logs
qwen-plus-20240223.txt

UT

(metagpt) MacBook-Pro:MetaGPT xxx$ pytest tests/metagpt/provider/test_qianfan_api.py                                                                                                                                                                 
tests/metagpt/provider/test_qianfan_api.py .                                                                                                                                                                                     [100%]

========================================================================================================== 1 passed in 0.05s ===================================================================
(metagpt) MacBook-Pro:MetaGPT xxx$ pytest tests/metagpt/provider/test_dashscope_api.py                                                                                                                                                                                                                
tests/metagpt/provider/test_dashscope_api.py .                                                                                                                                                                                   [100%]

========================================================================================================== 1 passed in 0.04s ======================================
(metagpt_v2) MacBook-Pro:MetaGPT xxxx$ pytest tests/metagpt/utils/test_repair_llm_raw_output.py 
========================================================================================================= test session starts ==========================================================================================================                                                                                                                                                                                                                    

tests/metagpt/utils/test_repair_llm_raw_output.py .......                                                                                                                                                                        [100%]

========================================================================================================== 7 passed in 3.83s ===========================================================================================================

Other

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 75.98425% with 61 lines in your changes are missing coverage. Please review.

Project coverage is 81.08%. Comparing base (06d7269) to head (ad88c50).
Report is 13 commits behind head on main.

Files Patch % Lines
metagpt/provider/dashscope_api.py 62.30% 49 Missing ⚠️
metagpt/provider/qianfan_api.py 91.95% 7 Missing ⚠️
metagpt/provider/base_llm.py 70.58% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #940      +/-   ##
==========================================
- Coverage   81.19%   81.08%   -0.12%     
==========================================
  Files         226      228       +2     
  Lines       12477    12726     +249     
==========================================
+ Hits        10131    10319     +188     
- Misses       2346     2407      +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@geekan geekan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geekan geekan merged commit d3961a6 into geekan:main Feb 28, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants