Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement made : by automating search engine configuration in example search_in_search_engine.py #965

Merged
merged 5 commits into from
Mar 11, 2024

Conversation

Abhishek0075
Copy link
Contributor

@Abhishek0075 Abhishek0075 commented Mar 5, 2024

Features
This is a change made for improving new user's experience. When the examples are run there can be some confusion.
So when I went through the examples\search_with_specific_engine.py there is a need for adding the api key and cse id explicitly and also need to uncomment and comment the code snippets according to our search engine preference
Through my updation i have made it easy by just using the config2.yaml configuration and doing the run
The user just need to run the program no need to bother about the code changes according to configurations.

Influence
It can make the new users' experience great and ease the usage of examples and understanding the code

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.16%. Comparing base (e12dde9) to head (cbfbecb).
Report is 130 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #965      +/-   ##
==========================================
- Coverage   82.08%   81.16%   -0.93%     
==========================================
  Files         226      226              
  Lines       12477    12477              
==========================================
- Hits        10242    10127     -115     
- Misses       2235     2350     +115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iorisa
Copy link
Collaborator

iorisa commented Mar 11, 2024

LGTM

@iorisa iorisa merged commit ea70fd5 into geekan:main Mar 11, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants