Non spec compliant unit test

[RAnders00]

go-twitch-irc/test_resources/irctests.json

Lines 205 to 215 in 1ea7808

	"Input": ":src AWAY ",
	"Expected": {
	"source": {
	"host": "src"
	},
	"command": "AWAY",
	"params": [
	""
	]
	}
	},

In this test, the expected output for the parameters is [""] (single element list, holding an empty string).

I think the IRC spec disagrees on this: https://tools.ietf.org/html/rfc2812#section-2.3.1
relevant part:

    params     =  *14( SPACE middle ) [ SPACE ":" trailing ]
    middle     =  nospcrlfcl *( ":" / nospcrlfcl )
    nospcrlfcl =  %x01-09 / %x0B-0C / %x0E-1F / %x21-39 / %x3B-FF
                    ; any octet except NUL, CR, LF, " " and ":"

So in essence the space between "middle" parameters is "used up" by the SPACE in the definition of params, and then middle first expects something that is not a space. From my understanding this means that multiple spaces are not allowed between middle parameters, and the IRC test under question should be an error.

[RAnders00]

There is also another unit test that relies on this behaviour:

go-twitch-irc/test_resources/irctests.json

Lines 326 to 338 in 1ea7808

	"Input": ":gravel.mozilla.org 432 #momo :Erroneous Nickname: Illegal characters",
	"Expected": {
	"source": {
	"host": "gravel.mozilla.org"
	},
	"command": "432",
	"params": [
	"",
	"#momo",
	"Erroneous Nickname: Illegal characters"
	]
	}
	},

I think this test case is taken from this bug discussion: https://bugzilla.mozilla.org/show_bug.cgi?id=954972 Where it was already discussed that sending a message like this would break IRC message parsers.