-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for banning users. #163
Conversation
Please add a test for it, otherwise looks fine |
I'm not that familar with github, how can I add a test? |
This has nothing to do with github. I'd like to have a unit test for this functionality. Other test for example https://github.com/gempir/go-twitch-irc/blob/master/client_test.go#L1007 Also the linter also still has issues with your code |
It might make sense to look at other tests like this as well because they actually assert the correct message which we want in this case. https://github.com/gempir/go-twitch-irc/blob/master/client_test.go#L1068 |
No description provided.