Add callbacks for self JOIN/PART messages #182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if it's good to invoke the client callbacks within handle functions for JOIN/PART but it just seemed the simplest.
I'm not familiar with library's code much, thus I don't have a good idea about what potentially relevant tests I could add, but I'm open to experimenting and writing something.thanks pajlada for help figuring that outOne small side-note I have: name of the callback
OnUserJoinMessage
might be confusing, indicating it's carrying JOIN message for our user because of theUser
part in its name (ideallyOnJoinMessage
andOnSelfJoinMessage
would make most sense to me). I know that's the name that was there from the beginning but I think it's only confusing if anything.That's nothing that I can change though, just pointing that out...
Closes #178