Migrate Button component from class to function style #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goenning
reviewed
Oct 27, 2021
public/components/common/Button.tsx
Outdated
| {props.children} | ||
| </a> | ||
| ) : ( | ||
| <button type={props.type} className={className} onClick={click}> |
There was a problem hiding this comment.
there's one scenario where a button won't have an href nor the onClick props. On the original version I had a third template without the onClick props.
I think we'd either need to go with that or change the click function to do absolutely nothing if props.onClick is undefined.
There was a problem hiding this comment.
Good catch 👍
I think having a third check is cleaner, I fix that asap.
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: This is the linked issue #730
In this PR I migrate Button component from class to function style using React hooks.
Friendly request: could you please label this PR with the label hacktoberfest-accepted when approved so it counts into the hacktoberfest 2021 challenge. Thank you in advance : )