Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that messages can be errors _or_ warnings #36209

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Feb 7, 2025

Why:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the preview environment.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

👓 Previews for changed content

This comment is 🤖 automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the review server. Please note that changes to the data directory will not show up in this table.

‼️ You can also preview changes using Codespaces or by spinning up a local environment. If you have trouble with the review server, use one of those options to preview your changes.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/sharing-automations/creating-actions/publishing-actions-in-github-marketplace.md fpt
ghec
fpt
ghec

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server
This table is posted from the Content Changes Table Comment workflow.

Copy link
Contributor

@isaacmbrown isaacmbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsoref, will get this merged for you

@isaacmbrown isaacmbrown added this pull request to the merge queue Feb 7, 2025
Merged via the queue into github:main with commit d16b9d7 Feb 7, 2025
49 checks passed
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@jsoref jsoref deleted the patch-2 branch February 7, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
2 participants