Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve example workflow #36384

Merged
merged 5 commits into from
Feb 21, 2025
Merged

Fix and improve example workflow #36384

merged 5 commits into from
Feb 21, 2025

Conversation

rufer7
Copy link
Contributor

@rufer7 rufer7 commented Feb 19, 2025

Why:

Closes: #36383 36383

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the preview environment.

Adjust text + enable workflow dispatch
- Improve comments
- Specify permissions granted to `GITHUB_TOKEN`
- Replace `$ORGANIZATION_VAR` with `${{ github.repository_owner }}`
- Add support for `null` in `last_activity_at`
- Replace placeholder `ORG/REPO` with `${{ github.repository }}`
- Fix env variable (see https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication#example-1-passing-the-github_token-as-an-input)
Copy link

welcome bot commented Feb 19, 2025

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Copy link
Contributor

github-actions bot commented Feb 19, 2025

👓 How to review these changes

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

⚠️ Warning: Our review server is experiencing latency issues.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on the review server. Changes to the data directory are not included in this table.

Source Review Production What Changed
copilot/rolling-out-github-copilot-at-scale/reminding-inactive-users.md fpt
ghec
fpt
ghec

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server
This table is posted from the Content Changes Table Comment workflow.

🤖 This comment is automatically generated.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 19, 2025
@sunbrye sunbrye self-requested a review February 21, 2025 04:07
sunbrye
sunbrye previously approved these changes Feb 21, 2025
Copy link
Contributor

@sunbrye sunbrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rufer7 Thank you for making a contribution and working through any bugs you found on the workflow ✨ The updates look great, especially the support for null last_activity_at. I'm going to approve and merge this PR ✅

Copy link
Contributor

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

⚠️ Warning: Our review server is experiencing latency issues.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on the review server. Changes to the data directory are not included in this table.

Source Review Production What Changed
copilot/rolling-out-github-copilot-at-scale/reminding-inactive-users.md fpt
ghec
fpt
ghec

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

@sunbrye sunbrye added this pull request to the merge queue Feb 21, 2025
Merged via the queue into github:main with commit 169c672 Feb 21, 2025
47 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@rufer7 rufer7 deleted the patch-1 branch February 21, 2025 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix and improve example workflow
2 participants