Reforeground debugger process after debugge exits #3919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekparker
requested changes
Feb 17, 2025
|
|
||
| // Process exited so we should "re-foreground" the main process, so that it can capture interrupts | ||
| if errors.As(err, &errProcessExited) && !tcxpgrp.IsForeground() { | ||
| pgid := syscall.Getpgrp() |
There was a problem hiding this comment.
The body of this branch can be folded into the branch below, I think.
Also, this functionality must be encapsulated somewhere else in a unix specific file, with another implementation available for Windows (can be stubbed initially if you don't plan to fix this for Windows in this PR). Can you place place this code in a function maybe within pkg/terminal/ somewhere with proper build tags via file name for unix/windows, might even be worth creating another small subpackage of terminal, but perhaps not. Then you can import and call here.
The reason is this layer of the code is supposed to be platform agnostic as much as possible.
|
A few things:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am debugging a bubbletea application and a lot of times I would love to mash CTRL-C to exit the application and then the server (that's two SIGINT signals). This very crude commit allows that. I also added a TODO for the windows side, because there the debugger needs to notify (via a channel) the
debugcommand to start capturing signals.One other thing that should probably be implemented is that client should exit on a headless server's exit.