Skip to content

Support RequestSampler in zipkin server middleware #812

Closed
@jcchavezs

Description

zipkin-go includes an option missing in this server middleware, RequestSampler which allows to change the sampling decision based on the request. This is specially useful when you want to sample requests coming from async operations (that often don't include tracing propagation) and in general to give more granularity to the sampling.

We are lacking that option in this server middleware, should I open a PR for that?

Ping @basvanbeek

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions