Correct http tags in tracing spans #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set correct value of HTTP URL tag that is added to client span in ToHTTPRequest() function. Add new opentracing tags in tracing request functions.
|
#376 Reference to PR |
peterbourgon
requested changes
Oct 11, 2016
There was a problem hiding this comment.
Sorry, I can see what you've done, but I don't quite understand why the previous version was incorrect. Can you spell it out for me? :) Thanks! /cc @bensigelman does this parse for you?
| "github.com/opentracing/opentracing-go/mocktracer" | ||
| "github.com/stretchr/testify/assert" |
There was a problem hiding this comment.
Please remove this dependency :)
danielfurman
commented
Oct 11, 2016
| @@ -21,7 +21,8 @@ func ToHTTPRequest(tracer opentracing.Tracer, logger log.Logger) kithttp.Request | |||
| // Try to find a Span in the Context. | |||
| if span := opentracing.SpanFromContext(ctx); span != nil { | |||
| // Add standard OpenTracing tags. | |||
| ext.HTTPMethod.Set(span, req.URL.RequestURI()) | |||
There was a problem hiding this comment.
@peterbourgon This is the place I was talking about.
Docs says that url.RequestURI() returns encoded path?query or opaque?querystring.
This value was assigned to a ext.HTTPMethod tag which i think is a bug.
There was a problem hiding this comment.
I see. Yes, great! Thank you.
peterbourgon
approved these changes
Oct 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set correct value of HTTP URL tag that is added to client span in ToHTTPRequest() function.
Add new opentracing tags in tracing request functions.