Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default file key string to caller #439

Merged
merged 1 commit into from
Jan 17, 2017
Merged

Change default file key string to caller #439

merged 1 commit into from
Jan 17, 2017

Conversation

willfaught
Copy link
Contributor

Fixes #432.

@willfaught
Copy link
Contributor Author

@peterbourgon Looks like TestGauge and TestCounter fail intermittently? Is there a way I can rerun the build?

@peterbourgon
Copy link
Member

peterbourgon commented Jan 17, 2017 •
edited
Loading

It's not you, it's Circonus. They write their lib so it's basically impossible to test, and change its behavior so the hacks I use stop working. I'll fix it in master and maybe you can rebase? Sorry for the noise.

@willfaught
Copy link
Contributor Author

Rebased

@peterbourgon
Copy link
Member

Nice! Thanks!

@peterbourgon peterbourgon merged commit 187650f into go-kit:master Jan 17, 2017
@willfaught willfaught deleted the caller branch January 17, 2017 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willfaught @peterbourgon