-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[transport/http] adding request and response encoders for Protobuf #809
Conversation
I've pushed updates with the new functions in a new subpackage: |
I've been thinking about the package name a bit and |
Go kit consumers are already essentially required to make use of import aliases to get e.g. |
Cool, I like this well enough. Any objections? I'll merge in a couple days otherwise. |
I don't mean to be a bugger, but any chance we can merge this one soon-ish? I'm working on some internal docs/boilerplates and would love to include this lil tidbit. |
Oh! I thought I'd done it. Mea culpa. |
Thanks, Peter! |
Bringing these over from our
marvin
framework now that we can use Gizmo + go-kit in Google App Engine (hooray!)I'm not 100% sure what we should do in the case of error while marshalling the protobuf so just commenting with a frowny face for now. Any thoughts for master...jprobinson:encode-proto#diff-05760750cf2e3aac59bd773896ee182fR202?
This resolves #808.