Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme: Autoformat layouts and assets #2931

Merged
merged 2 commits into from
Feb 18, 2025
Merged

theme: Autoformat layouts and assets #2931

merged 2 commits into from
Feb 18, 2025

Conversation

bep
Copy link
Member

@bep bep commented Feb 18, 2025

  • theme: Format layouts
  • theme: Format assets

@bep bep marked this pull request as draft February 18, 2025 13:12
```
npx prettier --write assets
```
```
npx prettier --write layouts
```
@bep bep requested a review from jmooring February 18, 2025 15:26
@bep bep marked this pull request as ready for review February 18, 2025 15:26
@bep
Copy link
Member Author

bep commented Feb 18, 2025

I have tried to be careful and manually inspected the diff, I think this should be safe/good. It would be good going forward if we could not have to worry too much about formatting.

@jmooring
Copy link
Member

My only comment is about... the comment. Can we do this:

{{- /* prettier-ignore-end */}}

Instead of this?

{{/* prettier-ignore-end */ -}}

My preference is to see white space removal syntax at the beginning of a line (and only at the end if necessary), but that's just me.

Otherwise this looks fine.

@bep
Copy link
Member Author

bep commented Feb 18, 2025

Instead of this?

I tried that, but that doesn't work with Prettier (it ERRORs).

@bep bep merged commit e684310 into gohugoio:master Feb 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants