dep ensure `--dry-run` seems broken

[tnozicka]

What version of Go (go version) and dep (git describe --tags) are you using?

go version go1.8.3 linux/amd64
dep - v0.3.0-22-g11758a7

What dep command did you run?

$ dep ensure
$ dep ensure --dry-run
Would have populated vendor/ directory from Gopkg.lock

What did you expect to see?

Empty output

What did you see instead?

Would have populated vendor/ directory from Gopkg.lock

The reason to use --dry-run is to see if there would be any changes done to e.g. check if vendor/ corresponds to current state of Gopkg.toml and .lock. It shouldn't say it would populate vendor/ if there are no changes.

[sdboyer]

It shouldn't say it would populate vendor/ if there are no changes.

it certainly shouldn't! problem is, we can't actually check if vendor/ is what Gopkg.lock says it should be right now. that's the capability that #121 will get us (and i'm very, very happy that we're now making progress in that direction - #959).

in the meantime, we've had to opt for the safe approach - just regenerating vendor/ on every dep ensure run.

[tnozicka]

If you regenerate vendor/ now, the easiest thing would be to compare the new directory with the old one. With that said if that solution should change shortly it might not worth the effort...

[sdboyer]

to compare the new directory with the old one.

hmm, i suppose we could generate some sort of diff output for this. if there's a lib out there that produces readable output, given two trees of input, then we could integrate it, for now.

and that might be worth it, because while the verification work is progressing nicely right now, it's still complex work. my conservative estimate is that it probably won't be fully wrapped up and in place for another couple months.

[JelteF]

It seems like you're looking for the functionality described here: #950

[sdboyer]

doing some queue-cleaning - the output here is now a fair bit clearer.