New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: check stream body is present on read timeout #162

Closed

AlexanderYastrebov wants to merge 1 commit into golang:master from AlexanderYastrebov:go58237

Contributor

AlexanderYastrebov commented Feb 2, 2023 •

edited

Loading

Check stream body is not nil in the handler to cover all callsites

For golang/go#58237

Contributor

gopherbot commented Feb 2, 2023

This PR (HEAD: 448c3c2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/464936 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

AlexanderYastrebov force-pushed the go58237 branch from 448c3c2 to 932138d Compare

February 2, 2023 22:12

Contributor

gopherbot commented Feb 2, 2023

This PR (HEAD: 932138d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/464936 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info


          http2: check stream body is present on read timeout

dc87bef

Check stream body is not nil in the handler to cover all callsites

For golang/go#58237

AlexanderYastrebov force-pushed the go58237 branch from 932138d to dc87bef Compare

July 21, 2023 21:31

Contributor

gopherbot commented Jul 21, 2023

This PR (HEAD: dc87bef) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/464936.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Contributor

gopherbot commented Jul 24, 2023

Message from Damien Neil:

Patch Set 3: Code-Review+2 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/464936.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 24, 2023

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/464936.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 24, 2023

Message from Gopher Robot:

Patch Set 3: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/464936.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 26, 2023

Message from Matthew Dempsky:

Patch Set 3: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/464936.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Aug 21, 2023

Message from Alexander Yastrebov:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/464936.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 19, 2023

Message from Alexander Yastrebov:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/464936.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          http2: check stream body is present on read timeout

ea63359

Check stream body is not nil in the handler to cover all callsites

For golang/go#58237

Change-Id: Ibeb19f2597f12da71b8dfb73718e230b4b316d06
GitHub-Last-Rev: dc87bef
GitHub-Pull-Request: #162
Reviewed-on: https://go-review.googlesource.com/c/net/+/464936
Reviewed-by: Bryan Mills <[email protected]>
Reviewed-by: Matthew Dempsky <[email protected]>
Run-TryBot: Damien Neil <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Damien Neil <[email protected]>
Auto-Submit: Bryan Mills <[email protected]>
Commit-Queue: Bryan Mills <[email protected]>

Contributor

gopherbot commented Sep 28, 2023

This PR is being closed because golang.org/cl/464936 has been merged.

gopherbot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet