-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
govet: skip fieldalignment test on 32bit platforms #5463
govet: skip fieldalignment test on 32bit platforms #5463
Conversation
Hey, thank you for opening your first Pull Request ! |
Hello, in which context do you need to run our tests inside a 32-bit arch? |
ran into this while working on the golangci-lint void package. also just in general, i feel like it would be nice if the tests work for all of the platforms you currently support / provide official binaries for (which currently includes armv6/7 and i386). |
We will not be able to maintain those tests because our CI doesn't use 32-bit arch (we will not add it inside our CI) and globally 32-bit arches are dead but 🤷 I don't understand why distribution packagers want to recompile everything and run tests: this is a Go program (statically linked) with no usage of CGO, not a C program dynamically linked. I will just ask to remove 32-bit tests because they will never be run inside our CI. |
alright, that sounds like a fair compromise. |
1e5e980
to
263829a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
the govet fieldalignment test currently fails on 32bit targets because it assumes
uintptr
always has a size of 8 bytes.this pr (edited after some discussion) adds build tags to skip it on platforms where that is not the case.