Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staticcheck #745

Merged
merged 2 commits into from
May 10, 2022
Merged

Staticcheck #745

merged 2 commits into from
May 10, 2022

Conversation

sbinet
Copy link
Member

@sbinet sbinet commented May 10, 2022

Please take a look.

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2022

Codecov Report

Merging #745 (9f76350) into master (e886fae) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 9f76350 differs from pull request most recent head 9555107. Consider uploading reports for the commit 9555107 to get more accurate results

@@            Coverage Diff             @@
##           master     #745      +/-   ##
==========================================
- Coverage   73.32%   73.23%   -0.09%     
==========================================
  Files          56       58       +2     
  Lines        5154     5366     +212     
==========================================
+ Hits         3779     3930     +151     
- Misses       1191     1243      +52     
- Partials      184      193       +9     
Impacted Files Coverage Δ
vg/recorder/recorder.go 86.31% <100.00%> (ø)
vg/vggio/context.go 100.00% <0.00%> (ø)
vg/vggio/vggio.go 67.37% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e886fae...9555107. Read the comment docs.

@sbinet
Copy link
Member Author

sbinet commented May 10, 2022

@kortschak PTAL.

(could you also remove the lint check as being required?)

@sbinet
Copy link
Member Author

sbinet commented May 10, 2022

PTAL

Copy link
Member

@kortschak kortschak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@sbinet sbinet merged commit 18129d8 into gonum:master May 10, 2022
@sbinet sbinet deleted the staticcheck branch May 10, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants