Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: bump to Go-1.19 #751

Merged
merged 5 commits into from
Aug 18, 2022
Merged

all: bump to Go-1.19 #751

merged 5 commits into from
Aug 18, 2022

Conversation

sbinet
Copy link
Member

@sbinet sbinet commented Aug 17, 2022

Please take a look.

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2022

Codecov Report

Merging #751 (fd8154f) into master (c2b6359) will increase coverage by 1.42%.
The diff coverage is n/a.

❗ Current head fd8154f differs from pull request most recent head 6dbf496. Consider uploading reports for the commit 6dbf496 to get more accurate results

@@            Coverage Diff             @@
##           master     #751      +/-   ##
==========================================
+ Coverage   73.32%   74.74%   +1.42%     
==========================================
  Files          56       58       +2     
  Lines        5154     7337    +2183     
==========================================
+ Hits         3779     5484    +1705     
- Misses       1191     1657     +466     
- Partials      184      196      +12     
Impacted Files Coverage Δ
vg/geom.go 76.00% <0.00%> (-5.25%) ⬇️
plotter/quartile.go 67.97% <0.00%> (-2.12%) ⬇️
palette/hsva.go 89.74% <0.00%> (-1.79%) ⬇️
text/plain.go 88.63% <0.00%> (-1.69%) ⬇️
plotter/errbars.go 86.56% <0.00%> (-1.44%) ⬇️
vg/vgpdf/vgpdf.go 68.58% <0.00%> (-1.29%) ⬇️
axis.go 85.96% <0.00%> (-0.99%) ⬇️
vg/tee.go 76.00% <0.00%> (-0.93%) ⬇️
palette/moreland/smooth.go 85.91% <0.00%> (-0.63%) ⬇️
plotter/line.go 90.38% <0.00%> (-0.42%) ⬇️
... and 45 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sbinet
Copy link
Member Author

sbinet commented Aug 18, 2022

@kortschak, do you understand why Go-1.19's test fails with Process completed with exit code 1. while there are no error being reported by go test ./... ?

(also: could you please remove the expected flag for 1.17.x ? thanks)

@kortschak
Copy link
Member

I have no idea why that is failing. It passes locally.

@kortschak
Copy link
Member

Maybe try running the tests if -v to see if that gives a hint. Otherwise, bisecting the packages to see which package is causing the problem might help.

@sbinet
Copy link
Member Author

sbinet commented Aug 18, 2022

aha! that was actually test -z "$(gofmt -d .)" (GitHub's CI UI was greatly misleading...)

Signed-off-by: Sebastien Binet <[email protected]>
@kortschak
Copy link
Member

That's horrific.

@sbinet
Copy link
Member Author

sbinet commented Aug 18, 2022

PTAL

@sbinet
Copy link
Member Author

sbinet commented Aug 18, 2022

I guess it doesn't handle well shell builtin functions ?
(anyways, there was also a bug in .ci/check-formatting.sh which should have made the initial error easier to spot)

Copy link
Member

@kortschak kortschak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are cases where we are using <pre> blocks to do lists. I think those can be done with the godoc mark up now.

@sbinet
Copy link
Member Author

sbinet commented Aug 18, 2022

PTAL

kortschak
kortschak previously approved these changes Aug 18, 2022
sbinet added 4 commits August 18, 2022 12:42
Signed-off-by: Sebastien Binet <[email protected]>
Signed-off-by: Sebastien Binet <[email protected]>
@sbinet
Copy link
Member Author

sbinet commented Aug 18, 2022

(force-push is only to clean up git history, no code change)

@sbinet sbinet merged commit b4f15d2 into gonum:master Aug 18, 2022
@sbinet sbinet deleted the go1.19 branch August 18, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants