-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: bump to Go-1.19 #751
all: bump to Go-1.19 #751
Conversation
Codecov Report
@@ Coverage Diff @@
## master #751 +/- ##
==========================================
+ Coverage 73.32% 74.74% +1.42%
==========================================
Files 56 58 +2
Lines 5154 7337 +2183
==========================================
+ Hits 3779 5484 +1705
- Misses 1191 1657 +466
- Partials 184 196 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@kortschak, do you understand why Go-1.19's test fails with (also: could you please remove the expected flag for |
I have no idea why that is failing. It passes locally. |
Maybe try running the tests if |
aha! that was actually |
Signed-off-by: Sebastien Binet <[email protected]>
That's horrific. |
PTAL |
I guess it doesn't handle well shell builtin functions ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are cases where we are using <pre> blocks to do lists. I think those can be done with the godoc mark up now.
PTAL |
Signed-off-by: Sebastien Binet <[email protected]>
Signed-off-by: Sebastien Binet <[email protected]>
Signed-off-by: Sebastien Binet <[email protected]>
Signed-off-by: Sebastien Binet <[email protected]>
(force-push is only to clean up git history, no code change) |
Please take a look.