Rename @maven -> @google_bazel_common_maven #198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Lam <[email protected]>
netdpb
reviewed
Oct 11, 2024
netdpb
approved these changes
Oct 14, 2024
|
@netdpb what else do I need to do to get this merged? |
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
Closes #198. PiperOrigin-RevId: 685853763
Nothing. We had to go through our internal merge process. Thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-root modules should not use
mavenas the name of maven closure as it can create duplicate artifacts/conflicts with other closure (and most importantly the closure created in the root module) -- see bazel-contrib/rules_jvm_external#916.This PR creates a custom namespace for maven jars that is used within
google_bazel_common, following similar patterns in