-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify DLOG macro definition in NDEBUG mode #830
Conversation
Codecov Report
@@ Coverage Diff @@
## master #830 +/- ##
==========================================
- Coverage 73.20% 73.17% -0.04%
==========================================
Files 17 17
Lines 3281 3277 -4
==========================================
- Hits 2402 2398 -4
Misses 879 879
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I have some minor remarks. Could you also please rebase?
Co-authored-by: Sergiu Deitsch <[email protected]>
@sergiud Thank you for your suggestions, I have edited |
Thanks! |
Simplify the DLOG macro definition in NDEBUG mode with consistent logic