Skip to content

Commit

Permalink
Improve CI configuration.
Browse files Browse the repository at this point in the history
This CL fixes the following issues:
* The Travis CI had the ctest invocation followed by a ";", so non-zero
  exit codes (indicating test failures) did not cause the build to fail.
* The AppVeyor CI had the ctest invocation followed by a ";", causing an
  error on Windows, where "&" plays the role of ";" [1].

The Windows CI (AppVeyor) will still be red after this CL, as some of
the tests are failing. However, this CL is a step forward, as it gets us
from failing to start tests to running tests and recording success/error
states.

[1] https://docs.microsoft.com/en-us/previous-versions/windows/it-pro/windows-xp/bb490954(v=technet.10)#using-multiple-commands-and-conditional-processing-symbols

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=236765633
  • Loading branch information
pwnall committed Mar 5, 2019
1 parent c69d33b commit 808e59e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
5 changes: 1 addition & 4 deletions .appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@ configuration:
- RelWithDebInfo
- Debug

build:
verbosity: minimal

build_script:
- git submodule update --init --recursive
- mkdir build
Expand All @@ -35,4 +32,4 @@ build_script:
- cd ..

test_script:
- cd build ; ctest --verbose ; cd ..
- cd build && ctest --verbose --build-config "%CONFIGURATION%" && cd ..
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ before_script:
- cd ..

script:
- cd build ; ctest --verbose ; cd ..
- cd build && ctest --verbose && cd ..
- "if [ -f build/db_bench ] ; then build/db_bench ; fi"
- "if [ -f build/db_bench_sqlite3 ] ; then build/db_bench_sqlite3 ; fi"
- "if [ -f build/db_bench_tree_db ] ; then build/db_bench_tree_db ; fi"

0 comments on commit 808e59e

Please sign in to comment.