Change std::uint64_t to uint64_t #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-This fixes compile errors with default setup on RHEL 6 systems.
sipa
pushed a commit
to sipa/leveldb
that referenced
this pull request
Apr 13, 2017
a31c8aa Add NewAppendableFile for win32 environment (Wladimir J. van der Laan) 3080a45 Increase leveldb version to 1.19. (cmumford) fa6dc01 A zippy change broke test assumptions about the size of compressed output. Fix the tests by allowing more slop in zippy's behavior. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=123432472 (sanjay) 06a191b fix problems in LevelDB's caching code (m3b) a7bff69 Fix LevelDB build when asserts are enabled in release builds. (google#367) (John Abd-El-Malek) ea992b4 Change std::uint64_t to uint64_t (google#354) (Nicholas Westlake) e84b5bd This CL fixes a bug encountered when reading records from leveldb files that have been split, as in a [] input task split. (mjwiacek) 3211343 Deleted redundant null ptr check prior to delete. (cmumford) 6b18316 Fix signed/unsigned mismatch on VC++ builds (Bruce Dawson) adbe3eb Putting build artifacts in subdirectory. (cmumford) dd1c3c3 add travis build badge (Lars-Magnus Skog) 9fcae61 Added a Travis CI build file. (Chris Mumford) 76bba13 fix indent (ideawu) 8fcceb2 log compaction output file's level along with number (ideawu) edf2939 Update README.md (Venilton FalvoJr) ceff6f1 Fix Android/MIPS build. (David Turner) 4753c9b Added a contributors section to README.md (cmumford) 0e0f074 documentation. improved link (Paul Irish) c85addc readme: improved documentation link (Paul Irish) 706b7f8 Resolve race when getting approximate-memory-usage property (ssid) 3c9ff3c Only compiling TrimSpace on linux. (cmumford) f8d205c Including atomic_pointer.h in port_posix (cmumford) 889de31 Let LevelDB use xcrun to determine Xcode.app path instead of using a hardcoded path. (ndmatthews) 528c2bc Add "approximate-memory-usage" property to leveldb::DB::GetProperty (ssid) 359b6bc Add leveldb::Cache::Prune (tzik) 50e77a8 Fix size_t/int comparison/conversion issues in leveldb. (pkasting) 5208e79 Added leveldb::Status::IsInvalidArgument() method. (cmumford) ce45404 Suppress error reporting after seeking but before a valid First or Full record is encountered. (Mike Wiacek) b9afa1f include <assert> -> <cassert> (Chris Mumford) 65190ac Will not reuse manifest if reuse_logs options is false. (Chris Mumford) ac1d69d LevelDB now attempts to reuse the preceding MANIFEST and log file when re-opened. (Sanjay Ghemawat) 77948e7 Add benchmark that measures cost of repeatedly opening the database. (Sanjay Ghemawat) 34ad72e Move header guard below copyright banner. (Chris Mumford) a75d435 Clean up layering of storage/leveldb/... (Chris Mumford) b234f65 Added a new fault injection test. (Chris Mumford) c4c38f9 Add arm64 support to leveldb. (Chris Mumford) cea9b10 Fixed incorrect comment wording for Iterator::Seek. (Chris Mumford) c00c569 Deleted old README file. (Chris Mumford) Tree-SHA512: 9f0ea5e306383be2691e79d17a4fd7093c0aec7e15e8ff257e06a938f0c1cb8af9ef610b870c8253f3bd18c09d5e4b0223a92987814c38ac38282a8c2cafa881
maochongxin
pushed a commit
to maochongxin/leveldb
that referenced
this pull request
Jul 21, 2022
fixes google#354 The build fails with ICC17 because of warnings and Werror. What is the correct solution to fix it? Should a patch disable Werror for ICC (or maybe all non known compilers) disable the false postive warnings for all files. This could be done using: add_cxx_compiler_flag(-wd2102) #ICC17u2: Many false positives for Wstrict-aliasing add_cxx_compiler_flag(-wd2259) #ICC17u2: non-pointer conversion from "long" to "int" may lose significant bits (even for explicit static cast, sleep.cc(44)) add_cxx_compiler_flag(-wd654) #ICC17u2: overloaded virtual function "benchmark::Fixture::SetUp" is only partially overridden (because of deprecated overload) disable warnings at file level or some other granularity
maochongxin
pushed a commit
to maochongxin/leveldb
that referenced
this pull request
Jul 21, 2022
Previously the constants used for converting between different units of time were declared using int64_t. However we should only use explicitly sized integer types when they are required, and should use 'int' everwhere else, and there is no good reason to use int64_t here. For that reason this patch changes the type of the constants. This should help address issue google#354 as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-This fixes compile errors with default setup on RHEL 6 systems.