Update CONTRIBUTING.md #778
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing a key word in the second sentence. Without "through", there is no direction of where the "jump" is going. Though it's implied, it's better if it's in the sentence.
cmumford
reviewed
Mar 2, 2020
| @@ -1,7 +1,7 @@ | |||
| # Contributing | |||
|
|
|||
| We'd love to accept your code patches! However, before we can take them, we | |||
| have to jump a couple of legal hurdles. | |||
| have to jump through a couple of legal hurdles. | |||
There was a problem hiding this comment.
Thx for the fix, but I think this is a mixed metaphor. One would either "jump through hoops" or "jump over hurdles".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing a key word in the second sentence. Without "through", there is no direction of where the "jump" is going. Though it's implied, it's better if it's in the sentence.