Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/10172 add woo commerce redirect modal #10232

Open
wants to merge 36 commits into
base: develop
Choose a base branch
from

Conversation

zutigrm
Copy link
Collaborator

@zutigrm zutigrm commented Feb 14, 2025

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@zutigrm zutigrm marked this pull request as ready for review February 20, 2025 13:15
Copy link

github-actions bot commented Feb 20, 2025

Build files for ec447c3 are ready:

This comment was marked as resolved.

Copy link
Collaborator

@eugene-manuilov eugene-manuilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @zutigrm. This is a good start but we still need to improve it. Please, see my comments.

@zutigrm
Copy link
Collaborator Author

zutigrm commented Feb 20, 2025

Thanks @eugene-manuilov PR updated

I updated IB for my other 2 issues, to take into the account dismissed items when marking modal open/close

Copy link
Collaborator

@eugene-manuilov eugene-manuilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @zutigrm. Mostly looks good to me. Left a few more comments.


const markModalDismissed = useCallback( () => {
onDismiss?.();
dismissItem( ADS_WOOCOMMERCE_REDIRECT_MODAL_DISMISS_KEY );
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @zutigrm. The last thing that we need to add here is 1 hour TTL for this dismissal. After that, this should be good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants