-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/10172 add woo commerce redirect modal #10232
base: develop
Are you sure you want to change the base?
Conversation
…add-WooCommerceRedirectModal.
…ine-data-datastore' into enhancement/10172-add-WooCommerceRedirectModal.
…add-WooCommerceRedirectModal.
Build files for ec447c3 are ready:
|
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @zutigrm. This is a good start but we still need to improve it. Please, see my comments.
assets/js/modules/ads/components/common/WooCommerceRedirectModal.js
Outdated
Show resolved
Hide resolved
assets/js/modules/ads/components/common/WooCommerceRedirectModal.js
Outdated
Show resolved
Hide resolved
assets/js/modules/ads/components/common/WooCommerceRedirectModal.js
Outdated
Show resolved
Hide resolved
Thanks @eugene-manuilov PR updated I updated IB for my other 2 issues, to take into the account dismissed items when marking modal open/close |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @zutigrm. Mostly looks good to me. Left a few more comments.
assets/js/modules/ads/components/common/WooCommerceRedirectModal.js
Outdated
Show resolved
Hide resolved
...ference/google-site-kit_Modules_Ads_WooCommerceRedirectModal_Default_0_document_1_medium.png
Outdated
Show resolved
Hide resolved
assets/js/modules/ads/components/common/WooCommerceRedirectModal.js
Outdated
Show resolved
Hide resolved
|
||
const markModalDismissed = useCallback( () => { | ||
onDismiss?.(); | ||
dismissItem( ADS_WOOCOMMERCE_REDIRECT_MODAL_DISMISS_KEY ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @zutigrm. The last thing that we need to add here is 1 hour TTL for this dismissal. After that, this should be good to go.
Summary
Addresses issue:
<WooCommerceRedirectModal>
Modal Component #10172Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist