importer: Add support for aged z database #36
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had trouble importing my
z
database since my database has been been aged many, many times 😄.So
z
uses aging which results in the db containing floats instead of ints:https://github.com/rupa/z/blob/9d5a3fe0407101e2443499e4b95bca33f7a9a9ca/z.sh#L83-L84
This PR fixes the following error during import (
jump import z
):I added a todo because I'm unsure what would be good / fair behavior. Rounding the values as-is to integers will give a slight advantage to results with a slightly lesser score (say, 22.2 vs 22.3 because both become 22).
I thought about multiplying with 100 to even it out a bit, but then I don't know what these scores would "mean" in
jump
.