feat: refactor CreateItems(...) to batch inserts #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimlambrt
force-pushed
the
jimlambrt-create-items
branch
2 times, most recently
from
97a971c to
8be13f4
Compare
jimlambrt
force-pushed
the
jimlambrt-create-items
branch
from
8be13f4 to
f40e362
Compare
tmessi
approved these changes
Jul 15, 2024
|
Note: I'll open a future PR to refactor the handling of OnConflict into a helper func shared between |
tmessi
reviewed
Jul 15, 2024
jimlambrt
force-pushed
the
jimlambrt-create-items
branch
from
a52e73d to
88524c6
Compare
jimlambrt
force-pushed
the
jimlambrt-create-items
branch
from
88524c6 to
f4e2c15
Compare
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I explored using pgxpool.SendBatch(...). Unfortunately, there doesn't appear to be a way to convert a gorm.DB or even an existing open sql.DB to a pgx type that can use SendBatch(...). Given that, I've fallen back to using gorm.CreateInBatches(...) which appears to be basically the same capability.