-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: ensure that LC_UUID is generated for Darwin binaries #13214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @edigaryev,
Thanks for digging into this and implementing the change, looking at the upstream issue and the Apple docs this should indeed fix that problem.
We'll release this as part of 1.12.0, scheduled for January.
Come to think of it, this is probably something we should roll out to plugins as well. I'll look into this right now.
Would there a way to get this earlier? Via a patch release or nightly?
This case is covered in the TN3179: Understanding local network privacy:
Packer is the responsible code here (which needs an UUID and will be shown as the source when displaying the dialog box asking for a permission), and plugins are "helper tools". |
To respond, yes, Nightlies starting today will have this baked-in, so anyone will be able to use As for the plugins, thanks for the tidbit, glad to hear that Packer alone will be enough to fix this problem :) Thanks for the PR and the extra information @edigaryev, much appreciated! |
Note: regarding Nightlies, they're built every day at ~00:00 UTC, so tomorrow, provided the release worked as expected, this should be available. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Problem: on macOS 15 (Sequoia), when Packer or any of its countless plugins attempt to connect to a directly attached network (including local VMs), the connection will currently fail, because having a
LC_UUID
identifier is critical for the local network privacy mechanism:Solution: bump Golang's minor revision and use the new
-B gobuildid
option, as suggested in golang/go#68678 (comment) to produce Packer binary with UUID.Fixes #13196.