fix: hard sticky strategy with no desired worker id #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mrkaye97
approved these changes
Jan 14, 2025
Comment on lines
192
to
+194
| if qi.DesiredWorkerId.Valid && workerId == sqlchelpers.UUIDToStr(qi.DesiredWorkerId) { | ||
| validSlots.addSlot(slot, 0) | ||
| } else if !qi.DesiredWorkerId.Valid { |
There was a problem hiding this comment.
nit (not blocking): can we use an or in the original condition? e.g.:
Suggested change
| if qi.DesiredWorkerId.Valid && workerId == sqlchelpers.UUIDToStr(qi.DesiredWorkerId) { | |
| validSlots.addSlot(slot, 0) | |
| } else if !qi.DesiredWorkerId.Valid { | |
| if (qi.DesiredWorkerId.Valid && workerId == sqlchelpers.UUIDToStr(qi.DesiredWorkerId)) || !qi.DesiredWorkerId.Valid { | |
| validSlots.addSlot(slot, 0) | |
| } |
There was a problem hiding this comment.
Yes, that's better, though I think it makes it more difficult to reason about -- probably something like this would work best?
matchesDesired := qi.DesiredWorkerId.Valid && workerId == sqlchelpers.UUIDToStr(qi.DesiredWorkerId)
desiredNotSet := !qi.DesiredWorkerId.Valid
if matchesDesired || desiredNotSet {
validSlots.addSlot(slot, 0)
}There was a problem hiding this comment.
yeah, that looks good to me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the case of
stickyStrategy=HARDand no desired worker id set, step runs can't be scheduled. This PR modifies the behavior to assign to any available worker in this case.We weren't seeing this behavior in most tests, because the workflows we were testing with
stickyStrategy=HARDwere child workflows spawned withsticky=True, where there's guaranteed to be a desired worker id.Type of change