feat: limits #559
feat: limits #559
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| return limits, nil | ||
| } | ||
|
|
||
| func (t *tenantLimitRepository) CanCreate(ctx context.Context, resource dbsqlc.LimitResource, tenantId string) (bool, error) { |
There was a problem hiding this comment.
We probably want to use the cache here, it's not ideal that every single lookup to determine whether to create an event/workflow run involves a database lookup, part of the design here would be to reduce the database load. I'd suggest at least caching for a minute here.
| @@ -40,6 +40,10 @@ type EngineRepository interface { | |||
| RateLimit() RateLimitEngineRepository | |||
| } | |||
|
|
|||
| type EntitlementsRepository interface { | |||
There was a problem hiding this comment.
Why do we have the EntitlementsRepository? Why not have the TenantLimitRepository as a direct call in the ApiRepository and EngineRepository which also gets passed as an argument to the metering struct?
There was a problem hiding this comment.
I figured it make more sense to separate this responsibility and share it across the two repositories. in the future we'll likely want to add additional things on the entitlement repositories (i.e. feature flags) so i think having it as its own thing make sense
| if err == pgx.ErrNoRows { | ||
| t.l.Warn().Msgf("no %s tenant limit found, creating default limit", string(resource)) | ||
|
|
||
| err = t.CreateTenantDefaultLimits(ctx, tenantId) |
There was a problem hiding this comment.
Just to clarify, this means that all existing tenants will get a limit set to the default?
There was a problem hiding this comment.
yes, on first meter it'll insert if none exists
Description
This PR introduces a new feature to impose and manage tenant-specific limits within our system. The key metrics being tracked include task executions per day, concurrent workers (burstable), and users. The feature includes mechanisms for alerting and blocking based on predefined usage thresholds.
Type of change
What's Changed