Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify tests by using t.TempDir() #96

Merged
merged 1 commit into from
Oct 30, 2024
Merged

simplify tests by using t.TempDir() #96

merged 1 commit into from
Oct 30, 2024

Conversation

alexandear
Copy link
Contributor

The PR refactors tests with t.TempDir:

TempDir returns a temporary directory for the test to use. The directory is automatically removed when the test and all its subtests complete. Each subsequent call to t.TempDir returns a unique directory; if the directory creation fails, TempDir terminates the test by calling Fatal.

@hhatto hhatto self-requested a review October 30, 2024 00:36
@hhatto
Copy link
Owner

hhatto commented Oct 30, 2024

@alexandear
Thanks for pull-request.
I have a conflict with merging #95. Cloud you please resolve it?

hhatto
hhatto approved these changes Oct 30, 2024
View reviewed changes
Copy link
Owner

@hhatto hhatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandear alexandear force-pushed the refactor/simplify-t-tempdir branch from bed7245 to c550f35 Compare October 30, 2024 10:06
@alexandear
Copy link
Contributor Author

@hhatto resolved conflicts

@hhatto hhatto merged commit 45c7196 into hhatto:master Oct 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhatto hhatto hhatto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @hhatto